Skip to content

tests.makeBinaryWrapper: fix cross test on aarch64-linux#255231

Merged
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:fixtestcrosswrap
Sep 16, 2023
Merged

tests.makeBinaryWrapper: fix cross test on aarch64-linux#255231
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:fixtestcrosswrap

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Sep 15, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Sep 15, 2023
@Artturin Artturin mentioned this pull request Sep 15, 2023
Merged
12 tasks
@rhendric
Copy link
Member

rhendric commented Sep 15, 2023

Also the case of the X is different?

@Artturin
Copy link
Member Author

Artturin commented Sep 15, 2023

Also the case of the X is different?

In the comparison both texts are made lowercase with ,,

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 15, 2023
@Artturin Artturin merged commit 512573a into NixOS:master Sep 16, 2023
@Artturin Artturin deleted the fixtestcrosswrap branch September 16, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Artturin @rhendric